Titles sticky to menubar instead of document top #9584
+94
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
✅ Change Note StatusAll change notes are properly formatted and validated! 📝 $:/changenotes/5.4.0/#9584Type: enhancement | Category: usability
🔗 #9584 👥 Contributors: BurningTreeC 📖 Change Note GuidelinesChange notes help track and communicate changes effectively. See the full documentation for details. |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pmario
reviewed
Jan 16, 2026
Refactor menubarObserver variable declaration to be local within the startup function.
Member
|
@BurningTreeC we should be able to use the mediaquery tracker/background actions from #8702 to simplify the approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular demand I try adding a startup module for the menubar plugin that tracks the height of the menubar and sets the css variable --tc-menubar-height that gets applied to the sticky titles so that they stick to the menubar and are not hidden by it